Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graphql concurrency issue with ContentPickerFiled #15734

Closed
wants to merge 1 commit into from
Closed

Fix graphql concurrency issue with ContentPickerFiled #15734

wants to merge 1 commit into from
+4 −5

Conversation

sebastienros
Copy link
Member

Fixes #15731

@sebastienros
Copy link
Member Author

@lampersky Can you check this PR?

@lampersky
Copy link
Contributor

@sebastienros I've just checked, and I'm still getting exception from time to time:

GraphQL.Execution.UnhandledError: Error trying to resolve field 'contentItems'.
 ---> System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at YesSql.Session.Get[T](IList`1 documents, String collection)
   at YesSql.Services.DefaultQuery.Query`1.ListImpl()
   at YesSql.Services.DefaultQuery.Query`1.ListImpl()
   at OrchardCore.ContentManagement.GraphQL.DataLoaderExtensions.LoadPublishedContentItemsAsync(IEnumerable`1 contentItemIds, ISession session)
   at GraphQL.DataLoader.CollectionBatchDataLoader`2.FetchAsync(IEnumerable`1 list, CancellationToken cancellationToken)
   at GraphQL.DataLoader.DataLoaderPair`2.GetResultAsync(CancellationToken cancellationToken) in /_/src/GraphQL.DataLoader/DataLoaderPair.cs:line 81
   at OrchardCore.ContentFields.GraphQL.SebContentPickerFieldQueryObjectType.<>c.<<-ctor>b__0_1>d.MoveNext() in C:\\repo\\Project.Core\\SebFix.cs:line 34
--- End of stack trace from previous location ---
   at GraphQL.Resolvers.FuncFieldResolver`2.<>c__DisplayClass3_0.<<-ctor>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at GraphQL.Execution.ExecutionStrategy.ExecuteNodeAsync(ExecutionContext context, ExecutionNode node) in /_/src/GraphQL/Execution/ExecutionStrategy.cs:line 472
   --- End of inner exception stack trace ---

image

@Piedone
Copy link
Member

Piedone commented Apr 24, 2024

@CodeRabbit review

@Piedone
Copy link
Member

Piedone commented Apr 24, 2024

Ooops, wrong CodeRabbit. @coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

@Piedone, I've reviewed the changes in the ContentPickerFieldQueryObjectType.cs file. The approach uses asynchronous data loading which is generally effective for handling large volumes of data concurrently. However, the concurrency issue reported might stem from how collections are handled during the data loading process.

Here are a few suggestions:

  1. Ensure Thread Safety: Verify that all collections used in the data loading process, especially those manipulated in the SelectMany operation, are thread-safe or properly synchronized.
  2. Review DataLoader Implementation: Check the implementation of GetOrAddPublishedContentItemByIdDataLoader to ensure it manages instances of data loaders in a thread-safe manner.
  3. Error Handling: Enhance error handling around data fetching operations to gracefully handle potential concurrency issues.

If these aspects are already handled, it might be beneficial to look into the specific scenarios under which the errors occur to further isolate the issue. If you need further analysis or specific code suggestions, feel free to let me know!

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Fetch the changes made in the PR
gh pr view 15734 --repo OrchardCMS/OrchardCore --json files --jq '.files[].path'

Length of output: 183

Script:

#!/bin/bash
# Read the contents of the modified file in the PR
cat src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/ContentPickerFieldQueryObjectType.cs

Length of output: 1519

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024 •
edited
Loading

Walkthrough

Walkthrough

The update involves modifying the ContentPickerFieldQueryObjectType class in the OrchardCore ContentFields module. Specifically, the method responsible for resolving content has been renamed from ResolveAsync to ResolveLockedAsync and now incorporates the async/await syntax for more efficient content item loading. This change enhances the method's ability to handle asynchronous operations and locking mechanisms more effectively.

Changes

File Path Change Summary
.../ContentFields/GraphQL/Types/ContentPickerFieldQueryObjectType.cs Renamed ResolveAsync to ResolveLockedAsync and updated to use async/await syntax for loading content items.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 112c0d4 and 81a9518.
Files selected for processing (1)
  • src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/ContentPickerFieldQueryObjectType.cs (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

...ardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/ContentPickerFieldQueryObjectType.cs Show resolved Hide resolved
@Piedone Piedone mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Closed
Open
Piedone
Piedone requested changes May 2, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes just to make it visible in the PR list too (#15734 (comment)).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

@github-actions github-actions bot added the stale label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

@github-actions github-actions bot closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Piedone Piedone Piedone requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GraphQL] A concurrent update was performed on this collection and corrupted its state.
3 participants
@sebastienros @lampersky @Piedone